net/http/http_cache.cc - Issue 761763003: Do not call GenerateCacheKey() if disk cache is disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache.cc

Issue 761763003: Do not call GenerateCacheKey() if disk cache is disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not call GenerateCacheKey() if disk cache is disabled. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/http/http_cache.cc

diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc

index a167e3200d5d3b44f1e47f70f9610cf698c14bb9..a34bef1158961bc78c29049ba89e0567990f99c1 100644

--- a/net/http/http_cache.cc

+++ b/net/http/http_cache.cc

@@ -603,7 +603,7 @@ void HttpCache::CloseIdleConnections() {

void HttpCache::OnExternalCacheHit(const GURL& url,

const std::string& http_method) {

- if (!disk_cache_.get())

+ if (!disk_cache_.get() || mode_ == DISABLE)

return;

HttpRequestInfo request_info;

« no previous file with comments | « no previous file | no next file » | no next file with comments »