Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 761643002: remove one place we read from gpu key in effects (Closed)

Created:
6 years ago by joshua.litt
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

remove one place we read from gpu key in effects BUG=skia: Committed: https://skia.googlesource.com/skia/+/60030bc2e1d9de455eb4ab2351ae0be494c97b4e

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -62 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 4 chunks +8 lines, -8 lines 1 comment Download
M src/effects/gradients/SkGradientShaderPriv.h View 2 chunks +2 lines, -18 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 10 chunks +20 lines, -20 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
joshualitt
6 years ago (2014-11-25 21:36:59 UTC) #2
bsalomon
lgtm
6 years ago (2014-11-25 21:51:05 UTC) #3
egdaniel
lgtm + nit https://codereview.chromium.org/761643002/diff/1/src/effects/gradients/SkGradientShader.cpp File src/effects/gradients/SkGradientShader.cpp (right): https://codereview.chromium.org/761643002/diff/1/src/effects/gradients/SkGradientShader.cpp#newcode1067 src/effects/gradients/SkGradientShader.cpp:1067: if (SkGradientShaderBase::kTwo_GpuColorType == ge.getColorType()){ space
6 years ago (2014-11-25 21:51:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761643002/1
6 years ago (2014-11-25 22:12:08 UTC) #9
commit-bot: I haz the power
6 years ago (2014-11-25 22:22:00 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/60030bc2e1d9de455eb4ab2351ae0be494c97b4e

Powered by Google App Engine
This is Rietveld 408576698