Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: src/gpu/GrDrawState.h

Issue 761563002: First step to moving vertex attributes to the geometryProcessor (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: adding test to ignore Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrDistanceFieldTextContext.cpp ('k') | src/gpu/GrDrawState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrDrawState.h
diff --git a/src/gpu/GrDrawState.h b/src/gpu/GrDrawState.h
index a049f1d8071e725d9dc96a3a1ac5b09a1c9dadbf..a236d1a55986b3aa717f24a272c7d069f28660c7 100644
--- a/src/gpu/GrDrawState.h
+++ b/src/gpu/GrDrawState.h
@@ -70,74 +70,17 @@ public:
/// @name Vertex Attributes
////
- enum {
- kMaxVertexAttribCnt = kLast_GrVertexAttribBinding + 4,
- };
-
- const GrVertexAttrib* getVertexAttribs() const { return fVAPtr; }
- int getVertexAttribCount() const { return fVACount; }
-
- size_t getVertexStride() const { return fVAStride; }
-
+ // TODO when we move this info off of GrGeometryProcessor, delete these
bool hasLocalCoordAttribute() const {
- return -1 != fFixedFunctionVertexAttribIndices[kLocalCoord_GrVertexAttribBinding];
+ return this->hasGeometryProcessor() && this->getGeometryProcessor()->hasLocalCoords();
}
bool hasColorVertexAttribute() const {
- return -1 != fFixedFunctionVertexAttribIndices[kColor_GrVertexAttribBinding];
+ return this->hasGeometryProcessor() && this->getGeometryProcessor()->hasVertexColor();
}
bool hasCoverageVertexAttribute() const {
- return -1 != fFixedFunctionVertexAttribIndices[kCoverage_GrVertexAttribBinding];
+ return this->hasGeometryProcessor() && this->getGeometryProcessor()->hasVertexCoverage();
}
- const int* getFixedFunctionVertexAttribIndices() const {
- return fFixedFunctionVertexAttribIndices;
- }
-
- bool validateVertexAttribs() const;
-
- /**
- * The format of vertices is represented as an array of GrVertexAttribs, with each representing
- * the type of the attribute, its offset, and semantic binding (see GrVertexAttrib in
- * GrTypesPriv.h).
- *
- * The mapping of attributes with kEffect bindings to GrProcessor inputs is specified when
- * setEffect is called.
- */
-
- /**
- * Sets vertex attributes for next draw. The object driving the templatization
- * should be a global GrVertexAttrib array that is never changed.
- *
- * @param count the number of attributes being set, limited to kMaxVertexAttribCnt.
- * @param stride the number of bytes between successive vertex data.
- */
- template <const GrVertexAttrib A[]> void setVertexAttribs(int count, size_t stride) {
- this->internalSetVertexAttribs(A, count, stride);
- }
-
- /**
- * Sets default vertex attributes for next draw. The default is a single attribute:
- * {kVec2f_GrVertexAttribType, 0, kPosition_GrVertexAttribType}
- */
- void setDefaultVertexAttribs();
-
- /**
- * Helper to save/restore vertex attribs
- */
- class AutoVertexAttribRestore {
- public:
- AutoVertexAttribRestore(GrDrawState* drawState);
-
- ~AutoVertexAttribRestore() { fDrawState->internalSetVertexAttribs(fVAPtr, fVACount,
- fVAStride); }
-
- private:
- GrDrawState* fDrawState;
- const GrVertexAttrib* fVAPtr;
- int fVACount;
- size_t fVAStride;
- };
-
/// @}
/**
@@ -765,8 +708,6 @@ private:
// This is used to assert that this condition holds.
SkDEBUGCODE(int fBlockEffectRemovalCnt;)
- void internalSetVertexAttribs(const GrVertexAttrib attribs[], int count, size_t stride);
-
typedef SkSTArray<4, GrFragmentStage> FragmentStageArray;
SkAutoTUnref<GrRenderTarget> fRenderTarget;
@@ -774,9 +715,6 @@ private:
SkMatrix fViewMatrix;
GrColor fBlendConstant;
uint32_t fFlagBits;
- const GrVertexAttrib* fVAPtr;
- int fVACount;
- size_t fVAStride;
GrStencilSettings fStencilSettings;
uint8_t fCoverage;
DrawFace fDrawFace;
@@ -787,10 +725,6 @@ private:
FragmentStageArray fCoverageStages;
uint32_t fHints;
- // This is simply a different representation of info in fVertexAttribs and thus does
- // not need to be compared in op==.
- int fFixedFunctionVertexAttribIndices[kGrFixedFunctionVertexAttribBindingCnt];
-
mutable GrProcOptInfo fColorProcInfo;
mutable GrProcOptInfo fCoverageProcInfo;
mutable bool fColorProcInfoValid;
« no previous file with comments | « src/gpu/GrDistanceFieldTextContext.cpp ('k') | src/gpu/GrDrawState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698