Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 761493004: Revert of Timeline: bring back FirstPaint marker and remove brown ticks near frame markers (Closed)

Created:
6 years ago by caseq
Modified:
6 years ago
Reviewers:
yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Revert of Timeline: bring back FirstPaint marker and remove brown ticks near frame markers (patchset #1 id:1 of https://codereview.chromium.org/732683002/) Reason for revert: This is wrong as it processes trace events from different trace threads and relied on their relative order. Let's do it right from scratch so that it's easier to merge. Original issue's description: > Timeline: bring back FirstPaint marker and remove brown ticks near frame markers > > - implement synthetic FirstPaint markers on front-end (they used to be generated > on the back-end with old Timeline instrumentation which is an ex-parrot) > - remove brown marks near the frame markers (regressed at r177959) > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185392 TBR=yurys@chromium.org,pfeldman@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186039

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -40 lines) Patch
M LayoutTests/inspector/tracing/timeline-load-event.html View 1 4 chunks +2 lines, -10 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-load-event-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 1 4 chunks +1 line, -17 lines 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caseq
Created Revert of Timeline: bring back FirstPaint marker and remove brown ticks near frame markers
6 years ago (2014-11-26 16:50:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761493004/1
6 years ago (2014-11-26 16:51:51 UTC) #2
commit-bot: I haz the power
Failed to apply patch for Source/devtools/front_end/timeline/TimelineModel.js: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years ago (2014-11-26 16:51:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761493004/120001
6 years ago (2014-11-26 17:00:58 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-26 17:01:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186039

Powered by Google App Engine
This is Rietveld 408576698