Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: Source/devtools/front_end/timeline/TimelineModel.js

Issue 761493004: Revert of Timeline: bring back FirstPaint marker and remove brown ticks near frame markers (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineModel.js
diff --git a/Source/devtools/front_end/timeline/TimelineModel.js b/Source/devtools/front_end/timeline/TimelineModel.js
index b89ef8924ef840e87b960dcee237e596753aba03..f201f323785e623a6400123d032f8519d6ef3df0 100644
--- a/Source/devtools/front_end/timeline/TimelineModel.js
+++ b/Source/devtools/front_end/timeline/TimelineModel.js
@@ -807,8 +807,6 @@ WebInspector.TimelineModel.prototype = {
this._lastRecalculateStylesEvent = null;
this._currentScriptEvent = null;
this._eventStack = [];
- this._layerTreeActivatedAfterLoad = false;
- this._expectFirstPaint = false;
},
/**
@@ -854,10 +852,6 @@ WebInspector.TimelineModel.prototype = {
if (endTime && event.startTime >= endTime)
break;
this._processEvent(event);
- if (this._expectFirstPaint && event.name === recordTypes.DrawFrame && this._layerTreeActivatedAfterLoad) {
- threadEvents.push(new WebInspector.TracingModel.Event(event.category, recordTypes.MarkFirstPaint, WebInspector.TracingModel.Phase.Instant, event.startTime, event.thread));
- this._expectFirstPaint = false;
- }
threadEvents.push(event);
this._inspectedTargetEvents.push(event);
}
@@ -869,6 +863,7 @@ WebInspector.TimelineModel.prototype = {
_processEvent: function(event)
{
var recordTypes = WebInspector.TimelineModel.RecordType;
+
var eventStack = this._eventStack;
while (eventStack.length && eventStack.peekLast().endTime < event.startTime)
eventStack.pop();
@@ -1036,17 +1031,6 @@ WebInspector.TimelineModel.prototype = {
event.backendNodeId = paintImageEvent.backendNodeId;
event.imageURL = paintImageEvent.imageURL;
break;
-
- case recordTypes.MarkDOMContent:
- if (!event.args["data"]["isMainFrame"])
- break;
- this._expectFirstPaint = true;
- this._layerTreeActivatedAfterLoad = false;
- break;
-
- case recordTypes.ActivateLayerTree:
- this._layerTreeActivatedAfterLoad = true;
- break;
}
},
« no previous file with comments | « LayoutTests/inspector/tracing/timeline-load-event-expected.txt ('k') | Source/devtools/front_end/timeline/timelinePanel.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698