Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 761303003: Add argument to pass elastic overscroll delta to Blink (Blink side) (Closed)

Created:
6 years ago by ccameron
Modified:
6 years ago
Reviewers:
enne (OOO)
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add argument to pass elastic overscroll delta to Blink (Blink side) Blink will need to use this argument to translate input events during overscroll. R=enne TBR=pfeldman BUG=133097 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186748

Patch Set 1 #

Patch Set 2 : Fix up types #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -9 lines) Patch
M Source/web/WebViewImpl.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 1 chunk +9 lines, -0 lines 0 comments Download
M Source/web/tests/PinchViewportTest.cpp View 1 8 chunks +9 lines, -9 lines 0 comments Download
M public/web/WebWidget.h View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ccameron
Plumbing cc -> blink for overscroll offset Other bit is https://codereview.chromium.org/783373002
6 years ago (2014-12-09 00:02:48 UTC) #2
enne (OOO)
lgtm
6 years ago (2014-12-09 00:21:42 UTC) #3
ccameron
Thanks!
6 years ago (2014-12-09 00:33:08 UTC) #4
ccameron
Putting pfeldman as TBR for public bits (lmk if you object to this use of ...
6 years ago (2014-12-09 00:33:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761303003/20001
6 years ago (2014-12-09 00:35:48 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-09 01:36:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186748

Powered by Google App Engine
This is Rietveld 408576698