Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 783373002: Add argument to pass elastic overscroll delta to Blink (Chrome side) (Closed)

Created:
6 years ago by ccameron
Modified:
6 years ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, danakj+watch_chromium.org, viettrungluu+watch_chromium.org, Ian Vollick, darin (slow to review), jam, yzshen+watch_chromium.org, abarth-chromium, jbauman+watch_chromium.org, Aaron Boodman, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, sievers+watch_chromium.org, ben+mojo_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add argument to pass elastic overscroll delta to Blink (Chrome side) Blink will need to use this argument to translate input events during overscroll. R=enne TBR=jam BUG=133097 Committed: https://crrev.com/98be9ac05260466ebd0da0373edebb0b20ef54b2 Cr-Commit-Position: refs/heads/master@{#307525}

Patch Set 1 #

Patch Set 2 : Update types #

Patch Set 3 : Remote TODOs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -25 lines) Patch
M android_webview/browser/hardware_renderer.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.h View 1 1 chunk +6 lines, -4 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 1 chunk +5 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_scroll_elasticity_controller.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/html_viewer/weblayertreeview_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
ccameron
Plumbing cc -> blink for overscroll offset Other bit is https://codereview.chromium.org/761303003/
6 years ago (2014-12-09 00:02:44 UTC) #2
enne (OOO)
lgtm
6 years ago (2014-12-09 00:21:39 UTC) #3
ccameron
Thanks! Adding TBR to jam -- let me know if you find this use of ...
6 years ago (2014-12-09 18:48:17 UTC) #4
ccameron
Thanks! Adding TBR to jam -- let me know if you find this use of ...
6 years ago (2014-12-09 18:48:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/783373002/40001
6 years ago (2014-12-09 18:51:47 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-09 19:56:40 UTC) #8
commit-bot: I haz the power
6 years ago (2014-12-09 19:57:36 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/98be9ac05260466ebd0da0373edebb0b20ef54b2
Cr-Commit-Position: refs/heads/master@{#307525}

Powered by Google App Engine
This is Rietveld 408576698