Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Issue 761283002: Remove webkit-line-clamp (Closed)

Created:
6 years ago by rafaelw
Modified:
6 years ago
Reviewers:
ojan
CC:
ojan, abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -124 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -20 lines 0 comments Download
M sky/engine/core/css/CSSProperties.in View 1 chunk +0 lines, -1 line 1 comment Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M sky/engine/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
D sky/engine/core/rendering/style/LineClampValue.h View 1 chunk +0 lines, -69 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 4 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.h View 2 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rafaelw
It's not obvious to me that this was doing anything, but it's gone now.
6 years ago (2014-11-28 04:55:42 UTC) #2
ojan
lgtm https://codereview.chromium.org/761283002/diff/1/sky/engine/core/css/CSSProperties.in File sky/engine/core/css/CSSProperties.in (right): https://codereview.chromium.org/761283002/diff/1/sky/engine/core/css/CSSProperties.in#newcode245 sky/engine/core/css/CSSProperties.in:245: -webkit-margin-top-collapse type_name=EMarginCollapse, name_for_methods=MarginBeforeCollapse If you're looking for more ...
6 years ago (2014-11-28 20:44:59 UTC) #3
rafaelw
6 years ago (2014-11-28 20:59:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f6f0eeb02d144848aa0fad0fe99f7c78c6223c5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698