sky/engine/core/css/CSSComputedStyleDeclaration.cpp - Issue 761283002: Remove webkit-line-clamp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/css/CSSComputedStyleDeclaration.cpp

Issue 761283002: Remove webkit-line-clamp (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/sky/engine/core/css/CSSComputedStyleDeclaration.cpp b/sky/engine/core/css/CSSComputedStyleDeclaration.cpp

index 205232119de4403fd92f75f51ba4ed1c598abb54..97ce7a1d0f576c3647f8c18fa8a28670210e933d 100644

--- a/sky/engine/core/css/CSSComputedStyleDeclaration.cpp

+++ b/sky/engine/core/css/CSSComputedStyleDeclaration.cpp

@@ -229,7 +229,6 @@ static const CSSPropertyID staticComputableProperties[] = {

CSSPropertyWebkitHyphenateCharacter,

CSSPropertyWebkitLineBoxContain,

CSSPropertyWebkitLineBreak,

- CSSPropertyWebkitLineClamp,

CSSPropertyWebkitLocale,

CSSPropertyWebkitMarginBeforeCollapse,

CSSPropertyWebkitMarginAfterCollapse,

@@ -1574,10 +1573,6 @@ PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getPropertyCSSValue(CSSPropert

if (!style->letterSpacing())

return cssValuePool().createIdentifierValue(CSSValueNormal);

return pixelValue(style->letterSpacing(), *style);

- case CSSPropertyWebkitLineClamp:

- if (style->lineClamp().isNone())

- return cssValuePool().createIdentifierValue(CSSValueNone);

- return cssValuePool().createValue(style->lineClamp().value(), style->lineClamp().isPercentage() ? CSSPrimitiveValue::CSS_PERCENTAGE : CSSPrimitiveValue::CSS_NUMBER);

case CSSPropertyLineHeight:

return valueForLineHeight(*style);

case CSSPropertyListStyleImage:

« no previous file with comments | « sky/engine/core/core.gni ('k') | sky/engine/core/css/CSSPrimitiveValueMappings.h » ('j') | sky/engine/core/css/CSSProperties.in » ('J')