Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 761103003: Revert of Add SSSE3 acceleration for S32_D16_filter_DXDY (Closed)

Created:
6 years ago by jam
Modified:
6 years ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of Add SSSE3 acceleration for S32_D16_filter_DXDY (patchset #3 id:40001 of https://codereview.chromium.org/773753002/) Reason for revert: breaks build when not using SSE3, since the two method definitions differ in parameter types (typo) Original issue's description: > Add SSSE3 acceleration for S32_D16_filter_DXDY > > With this CL, related nanobench can be improved for 565 config. > bitmap_BGRA_8888_scale_rotate_bilerp 115us -> 70.5us 0.61x > bitmap_BGRA_8888_update_volatile_scale_rotate_bilerp 115us -> 70.5us 0.61x > bitmap_BGRA_8888_update_scale_rotate_bilerp 112us -> 68us 0.6x > > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/45a05780867a06b9f8a8d5240cf6c5d5a2c15a35 TBR=mtklein@google.com,qkmiao@gmail.com,qiankun.miao@intel.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/9da051ad417c13eb562c91ef6286f92dba2ae232

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -39 lines) Patch
M src/core/SkBitmapProcState.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/opts/SkBitmapProcState_opts_SSSE3.cpp View 3 chunks +8 lines, -26 lines 0 comments Download
M src/opts/opts_check_x86.cpp View 2 chunks +4 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jam
Created Revert of Add SSSE3 acceleration for S32_D16_filter_DXDY
6 years ago (2014-12-03 23:19:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/761103003/1
6 years ago (2014-12-03 23:19:52 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years ago (2014-12-03 23:19:52 UTC) #3
tfarina
lgtm
6 years ago (2014-12-03 23:55:46 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-03 23:56:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9da051ad417c13eb562c91ef6286f92dba2ae232

Powered by Google App Engine
This is Rietveld 408576698