PlzNavigate: add support in several navigation controller unit tests

content/test/test_render_frame_host.h

Index: content/test/test_render_frame_host.h
diff --git a/content/test/test_render_frame_host.h b/content/test/test_render_frame_host.h
index a828bd56a09fcbdf73ff57527d5967ae4bdae0b7..a525ac23f8a7d8e52e158dd74ad14e86304d47d5 100644
--- a/content/test/test_render_frame_host.h
+++ b/content/test/test_render_frame_host.h
@@ -87,6 +87,8 @@ class TestRenderFrameHost : public RenderFrameHostImpl,
 
   void DidDisownOpener();
 
+  void SendRendererResponseToNavigation(bool proceed, const GURL& url);
+
   // If set, navigations will appear to have cleared the history list in the
   // RenderFrame
   // (FrameHostMsg_DidCommitProvisionalLoad_Params::history_list_was_cleared).
@@ -95,7 +97,10 @@ class TestRenderFrameHost : public RenderFrameHostImpl,
     simulate_history_list_was_cleared_ = cleared;
   }
 
+  // PlzNavigate
+  void SimulateIOThread(const GURL& url);

[nasko, 2014/12/16 01:40:26]

This is a bit too specific of a name for unit tests to call. Can we abstract the
name somehow to a higher level concept that happens regardless of the mode of
operation? I like the above "SendRendererResponse...", which is clear as to what
it does and in response to what event.

[clamy, 2014/12/16 19:19:05]

Would the name MakeNavigationReadyForCommit be better? I could also modify the
function so that it does the logic found in the NavigationControllerTests (ie if
PlzNavigate what this function currently does otherwise simulate the
BeforeUnload ack).

[nasko, 2014/12/17 00:55:02]

PrepareForCommit? Or yours works too.
Yes, I think I made such a comment in the actual unit tests file, as the pattern
was used in a few places.

[clamy, 2014/12/17 15:47:58]

Done.

  private:
+

[nasko, 2014/12/16 01:40:26]

nit: no need for empty line here, rather above "private:"

[clamy, 2014/12/17 15:47:57]

Done.

   TestRenderFrameHostCreationObserver child_creation_observer_;
 
   std::string contents_mime_type_;