PlzNavigate: add support in several navigation controller unit tests

content/test/test_render_frame_host.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_TEST_TEST_RENDER_FRAME_HOST_H_
 #define CONTENT_TEST_TEST_RENDER_FRAME_HOST_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 69 matching lines @@
       const GURL& url,
       ui::PageTransition transition,
       const GURL& original_request_url,
       int response_code,
       const base::FilePath* file_path_for_history_item,
       const std::vector<GURL>& redirects);
   void SendBeginNavigationWithURL(const GURL& url);
 
   void DidDisownOpener();
 
+  void SendRendererResponseToNavigation(bool proceed, const GURL& url);
+
   // If set, navigations will appear to have cleared the history list in the
   // RenderFrame
   // (FrameHostMsg_DidCommitProvisionalLoad_Params::history_list_was_cleared).
   // False by default.
   void set_simulate_history_list_was_cleared(bool cleared) {
     simulate_history_list_was_cleared_ = cleared;
   }
 
+  // PlzNavigate
+  void SimulateIOThread(const GURL& url);

[nasko, 2014/12/16 01:40:26]

This is a bit too specific of a name for unit tests to call. Can we abstract the
name somehow to a higher level concept that happens regardless of the mode of
operation? I like the above "SendRendererResponse...", which is clear as to what
it does and in response to what event.

[clamy, 2014/12/16 19:19:05]

Would the name MakeNavigationReadyForCommit be better? I could also modify the
function so that it does the logic found in the NavigationControllerTests (ie if
PlzNavigate what this function currently does otherwise simulate the
BeforeUnload ack).

[nasko, 2014/12/17 00:55:02]

PrepareForCommit? Or yours works too.
Yes, I think I made such a comment in the actual unit tests file, as the pattern
was used in a few places.

[clamy, 2014/12/17 15:47:58]

Done.

  private:
+

[nasko, 2014/12/16 01:40:26]

nit: no need for empty line here, rather above "private:"

[clamy, 2014/12/17 15:47:57]

Done.

   TestRenderFrameHostCreationObserver child_creation_observer_;
 
   std::string contents_mime_type_;
 
   // See set_simulate_history_list_was_cleared() above.
   bool simulate_history_list_was_cleared_;
 
   DISALLOW_COPY_AND_ASSIGN(TestRenderFrameHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_TEST_TEST_RENDER_FRAME_HOST_H_