Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 760753003: Add float-to-half (binary16) conversion functions. (Closed)

Created:
6 years ago by jvanverth1
Modified:
6 years ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add float-to-half (binary16) conversion functions. Based on code by Fabian Giesen at https://fgiesen.wordpress.com/2012/03/28/half-to-float-done-quic/. These will be needed for creating binary16 textures from floating point data. BUG=skia:3103 Committed: https://skia.googlesource.com/skia/+/936799204b34e7a2f20ac6c0868058799ceb851e

Patch Set 1 #

Patch Set 2 : Fix unsigned issue on Ubuntu. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -0 lines) Patch
M gyp/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A src/core/SkHalf.h View 1 chunk +22 lines, -0 lines 0 comments Download
A src/core/SkHalf.cpp View 1 chunk +97 lines, -0 lines 0 comments Download
M tests/MathTest.cpp View 1 3 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jvanverth1
6 years ago (2014-11-26 20:07:54 UTC) #2
bsalomon
lgtm
6 years ago (2014-11-26 20:33:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760753003/1
6 years ago (2014-11-26 20:54:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot/builds/885) Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot/builds/897)
6 years ago (2014-11-26 20:55:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760753003/20001
6 years ago (2014-11-26 21:06:06 UTC) #9
commit-bot: I haz the power
6 years ago (2014-11-26 21:16:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/936799204b34e7a2f20ac6c0868058799ceb851e

Powered by Google App Engine
This is Rietveld 408576698