tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py - Issue 760653002: Telemetry --device

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py

Issue 760653002: Telemetry --device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py ('k') | tools/telemetry/telemetry/core/backends/chrome/ios_browser_finder.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py

index 8f8dc1f295619b778bf246c36854db9079832101..14abe60c1ed6e29f22eb1cb805068acf3882d28b 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py

@@ -5,6 +5,7 @@ import unittest

from telemetry.core import browser_options

from telemetry.core.backends.chrome import desktop_browser_finder

+from telemetry.core.platform import desktop_device

from telemetry.unittest_util import system_stub

@@ -32,7 +33,8 @@ class FindTestBase(unittest.TestCase):

return self._path_stubs.os.path.files

def DoFindAll(self):

- return desktop_browser_finder.FindAllAvailableBrowsers(self._finder_options)

+ return desktop_browser_finder.FindAllAvailableBrowsers(

+ self._finder_options, desktop_device.DesktopDevice())

def DoFindAllTypes(self):

browsers = self.DoFindAll()