Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py

Issue 760653002: Telemetry --device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py
index e396081365e097ad12fb7c4daf955cd47aea0be5..e2fba9e724673fd5125d233ffec58e4d0b050ae1 100644
--- a/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py
+++ b/tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder.py
@@ -13,6 +13,7 @@ from telemetry.core import browser
from telemetry.core import exceptions
from telemetry.core import possible_browser
from telemetry.core.backends.chrome import desktop_browser_backend
+from telemetry.core.platform import desktop_device
from telemetry.util import path
@@ -113,8 +114,11 @@ def FindAllBrowserTypes(_):
'content-shell-release_x64',
'system']
-def FindAllAvailableBrowsers(finder_options):
+def FindAllAvailableBrowsers(finder_options, device):
"""Finds all the desktop browsers available on this machine."""
+ if not isinstance(device, desktop_device.DesktopDevice):
+ return []
+
browsers = []
if not CanFindAvailableBrowsers():

Powered by Google App Engine
This is Rietveld 408576698