Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 760173002: Revert of gpu: fix CopyTextureCHROMIUM for immutable texture. (Closed)

Created:
6 years ago by Ken Russell (switch to Gerrit)
Modified:
6 years ago
Reviewers:
dshwang, reveman, no sievers
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of gpu: fix CopyTextureCHROMIUM for immutable texture. (patchset #4 id:60001 of https://codereview.chromium.org/744713002/) Reason for revert: Broke video uploads to WebGL on official builds (taking the hardware accelerated video decode path). See Issue 436538. Original issue's description: > gpu: fix CopyTextureCHROMIUM for immutable texture. > > We cannot use glCopyTexImage2D on the texture which is allocated by glTexStorage2D [1] > [1] https://www.opengl.org/registry/specs/ARB/texture_storage.txt > The fast path uses glCopyTexSubImage2D instead of glCopyTexImage2D. > > In addition, optimize CopyTextureCHROMIUM for GL_TEXTURE_RECTANGLE_ARB, > which is often used by the compositor, so make CopyTextureCHROMIUM use > the fast path. > > Committed: https://crrev.com/df36f0aebe453bdbe842c85b331f6f07a24255a2 > Cr-Commit-Position: refs/heads/master@{#305268} TBR=sievers@chromium.org,reveman@chromium.org,dongseong.hwang@intel.com BUG=436538 Committed: https://crrev.com/e3558eac30baa00fe4bb4c1aa79f21185c98b485 Cr-Commit-Position: refs/heads/master@{#305937}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -42 lines) Patch
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 3 chunks +13 lines, -5 lines 0 comments Download
M gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Ken Russell (switch to Gerrit)
Created Revert of gpu: fix CopyTextureCHROMIUM for immutable texture.
6 years ago (2014-11-27 00:48:14 UTC) #1
Ken Russell (switch to Gerrit)
Note: I'm sending this through the CQ to make sure nothing depended on the original ...
6 years ago (2014-11-27 00:48:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/760173002/1
6 years ago (2014-11-27 00:50:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-11-27 01:50:27 UTC) #5
commit-bot: I haz the power
6 years ago (2014-11-27 01:51:07 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3558eac30baa00fe4bb4c1aa79f21185c98b485
Cr-Commit-Position: refs/heads/master@{#305937}

Powered by Google App Engine
This is Rietveld 408576698