chrome/browser/ui/views/uninstall_view.cc - Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/uninstall_view.cc

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chrome build Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/uninstall_view.cc

diff --git a/chrome/browser/ui/views/uninstall_view.cc b/chrome/browser/ui/views/uninstall_view.cc

index 0ce1b0359fe305c24ef62b697a2b14e872a893ed..b8f4b845278d993bc1238f77a10986ee1f68bd84 100644

--- a/chrome/browser/ui/views/uninstall_view.cc

+++ b/chrome/browser/ui/views/uninstall_view.cc

@@ -118,7 +118,7 @@ bool UninstallView::Accept() {

std::advance(i, browsers_combo_->selected_index());

base::LaunchOptions options;

options.start_hidden = true;

- base::LaunchProcess(i->second, options, NULL);

+ base::LaunchProcess(i->second, options);

}

return true;

}

« no previous file with comments | « chrome/browser/first_run/upgrade_util_win.cc ('k') | chrome/installer/gcapi/gcapi.cc » ('j') | no next file with comments »