chrome/browser/first_run/upgrade_util_win.cc - Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/first_run/upgrade_util_win.cc

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix chrome build Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/native_process_launcher_win.cc ('k') | chrome/browser/ui/views/uninstall_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/first_run/upgrade_util_win.cc

diff --git a/chrome/browser/first_run/upgrade_util_win.cc b/chrome/browser/first_run/upgrade_util_win.cc

index ff19c0479d7af3528e03c702e7762c9e35861e9a..1a489a859bf74ee4d73754bab48c80a5bf544caf 100644

--- a/chrome/browser/first_run/upgrade_util_win.cc

+++ b/chrome/browser/first_run/upgrade_util_win.cc

@@ -258,13 +258,13 @@ bool SwapNewChromeExeIfPresent() {

std::wstring rename_cmd;

if (key.ReadValue(google_update::kRegRenameCmdField,

&rename_cmd) == ERROR_SUCCESS) {

- base::win::ScopedHandle handle;

base::LaunchOptions options;

options.wait = true;

options.start_hidden = true;

- if (base::LaunchProcess(rename_cmd, options, &handle)) {

+ base::Process process = base::LaunchProcess(rename_cmd, options);

+ if (process.IsValid()) {

DWORD exit_code;

- ::GetExitCodeProcess(handle.Get(), &exit_code);

+ ::GetExitCodeProcess(process.Handle(), &exit_code);

if (exit_code == installer::RENAME_SUCCESSFUL)

return true;

}