Upgrade the windows specific version of LaunchProcess to avoid raw handles.

chrome/browser/extensions/api/messaging/native_process_launcher_win.cc

Index: chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc b/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
index 59b1b39bb30b4e5896bf8d4ce72b6324d9e23722..d0ae6edba0c4682d6937a5de0ae0e5d494919d7c 100644
--- a/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
+++ b/chrome/browser/extensions/api/messaging/native_process_launcher_win.cc
@@ -89,7 +89,7 @@ base::FilePath NativeProcessLauncher::FindManifest(
 // static
 bool NativeProcessLauncher::LaunchNativeProcess(
     const CommandLine& command_line,
-    base::ProcessHandle* process_handle,
+    base::Process* process,
     base::File* read_file,
     base::File* write_file) {
   // Timeout for the IO pipes.
@@ -151,8 +151,8 @@ bool NativeProcessLauncher::LaunchNativeProcess(
 
   base::LaunchOptions options;
   options.start_hidden = true;
-  base::win::ScopedHandle cmd_handle;
-  if (!base::LaunchProcess(command.c_str(), options, &cmd_handle)) {
+  base::Process cmd_process = base::LaunchProcess(command.c_str(), options);

[grt (UTC plus 2), 2014/11/26 16:14:13]

Gab discovered in crbug.com/436072 that this launch is problematic because the
launched process's CWD is Chrome's version directory. Since the spawned process
keeps that handle open for its lifetime, it interferes with Chrome updates and
uninstalls. Could you make this set the launched proc's CWD to
command_line.GetProgram().DirName() (or anything other than Chrome's CWD)? It
looks like it'll take plumbing in launch{.h,_win.cc} to make this possible, so
it's probably best to do it in its own CL. Thanks.

[rvargas (doing something else), 2014/11/26 18:16:20]

That is certainly interesting, but that seems out of scope of the current change
(and the bug it is trying to fix)

+  if (!cmd_process.IsValid()) {
     LOG(ERROR) << "Error launching process "
                << command_line.GetProgram().MaybeAsASCII();
     return false;
@@ -163,13 +163,13 @@ bool NativeProcessLauncher::LaunchNativeProcess(
   bool stdin_connected = ConnectNamedPipe(stdin_pipe.Get(), NULL) ?
       TRUE : GetLastError() == ERROR_PIPE_CONNECTED;
   if (!stdout_connected || !stdin_connected) {
-    base::KillProcess(cmd_handle.Get(), 0, false);
+    base::KillProcess(cmd_process.Handle(), 0, false);
     LOG(ERROR) << "Failed to connect IO pipes when starting "
                << command_line.GetProgram().MaybeAsASCII();
     return false;
   }
 
-  *process_handle = cmd_handle.Take();
+  *process = cmd_process.Pass();
   *read_file = base::File(stdout_pipe.Take());
   *write_file = base::File(stdin_pipe.Take());