chrome/browser/extensions/api/messaging/native_process_launcher.h - Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/messaging/native_process_launcher.h

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/messaging/native_message_process_host.cc ('K') | « chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc ('k') | chrome/browser/extensions/api/messaging/native_process_launcher.cc » ('j') | chrome/browser/extensions/api/messaging/native_process_launcher_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/messaging/native_process_launcher.h

diff --git a/chrome/browser/extensions/api/messaging/native_process_launcher.h b/chrome/browser/extensions/api/messaging/native_process_launcher.h

index db4130946119f56057e86f57f11bd4d1e846817d..c99d37bdb26676ad61922d51404044c84c534d7e 100644

--- a/chrome/browser/extensions/api/messaging/native_process_launcher.h

+++ b/chrome/browser/extensions/api/messaging/native_process_launcher.h

@@ -34,7 +34,7 @@ class NativeProcessLauncher {

// to false in case of a failure. Handler must take ownership of the IO

// handles.

typedef base::Callback<void(LaunchResult result,

- base::ProcessHandle process_handle,

+ base::Process process,

base::File read_file,

base::File write_file)> LaunchedCallback;

@@ -68,7 +68,7 @@ class NativeProcessLauncher {

// Launches native messaging process.

static bool LaunchNativeProcess(const base::CommandLine& command_line,

- base::ProcessHandle* process_handle,

+ base::Process* process_handle,

gab 2014/11/27 13:28:44 s/process_handle/process

base::File* read_file,

base::File* write_file);