Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: base/process/launch_win.cc

Issue 759903002: Upgrade the windows specific version of LaunchProcess to avoid raw handles. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/process/launch_win.cc
diff --git a/base/process/launch_win.cc b/base/process/launch_win.cc
index a3303a5e08588669aac9d84cf6f9acdb2473b594..003bc15828118f8fbdd07ce9197750e5140cf0ba 100644
--- a/base/process/launch_win.cc
+++ b/base/process/launch_win.cc
@@ -232,6 +232,17 @@ bool LaunchProcess(const string16& cmdline,
return true;
}
+// TODO(rvargas) crbug.com/416721: Remove this stub after LaunchProcess is
+// fully migrated to use Process.
+Process LaunchProcess(const string16& cmdline,
+ const LaunchOptions& options) {
+ win::ScopedHandle process;
gab 2014/11/27 13:28:44 s/process/process_handle (for naming consistency w
rvargas (doing something else) 2014/12/01 20:50:36 Done.
+ if (LaunchProcess(cmdline, options, &process))
+ return Process(process.Take());
+
+ return Process();
+}
+
bool LaunchProcess(const CommandLine& cmdline,
gab 2014/11/27 13:28:44 Is this still needed? (and similarly should that d
rvargas (doing something else) 2014/12/01 20:50:36 Yeah, this function is what prevents me from switc
const LaunchOptions& options,
ProcessHandle* process_handle) {

Powered by Google App Engine
This is Rietveld 408576698