Upgrade the windows specific version of LaunchProcess to avoid raw handles.

base/process/launch_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/process/launch.h"
 
 #include <fcntl.h>
 #include <io.h>
 #include <shellapi.h>
 #include <windows.h>
@@ skipping 214 matching lines @@
   if (options.wait)
     WaitForSingleObject(process_info.process_handle(), INFINITE);
 
   // If the caller wants the process handle, we won't close it.
   if (process_handle)
     process_handle->Set(process_info.TakeProcessHandle());
 
   return true;
 }
 
+// TODO(rvargas) crbug.com/416721: Remove this stub after LaunchProcess is
+// fully migrated to use Process.
+Process LaunchProcess(const string16& cmdline,
+                      const LaunchOptions& options) {
+  win::ScopedHandle process;

[gab, 2014/11/27 13:28:44]

s/process/process_handle
(for naming consistency with everything else in this file and this CL)

[rvargas (doing something else), 2014/12/01 20:50:36]

Done.

+  if (LaunchProcess(cmdline, options, &process))
+    return Process(process.Take());
+
+  return Process();
+}
+
 bool LaunchProcess(const CommandLine& cmdline,

[gab, 2014/11/27 13:28:44]

Is this still needed? (and similarly should that definition be ifdef'ed out in
the header on OS_WIN?)

Or are we not there yet? Perhaps this is actually what you meant by the comment
on line 235, sorry about the noise if that's the case :-)!

[rvargas (doing something else), 2014/12/01 20:50:36]

Yeah, this function is what prevents me from switching right away the contract
of the win-specific override :(. And this will take multiple CLs as this version
is used everywhere.

                    const LaunchOptions& options,
                    ProcessHandle* process_handle) {
   if (!process_handle)
     return LaunchProcess(cmdline.GetCommandLineString(), options, NULL);
 
   win::ScopedHandle process;
   bool rv = LaunchProcess(cmdline.GetCommandLineString(), options, &process);
   *process_handle = process.Take();
   return rv;
 }
@@ skipping 117 matching lines @@
   WaitForSingleObject(proc_info.process_handle(), INFINITE);
 
   return true;
 }
 
 void RaiseProcessToHighPriority() {
   SetPriorityClass(GetCurrentProcess(), HIGH_PRIORITY_CLASS);
 }
 
 }  // namespace base