Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 759893002: IDL: Auto-generate NativeValueTraits for IDL dictionaries (Closed)

Created:
6 years ago by bashi
Modified:
6 years ago
Reviewers:
haraken, Jens Widell
CC:
blink-reviews, blink-reviews-bindings_chromium.org, philipj_slow, arv+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Auto-generate NativeValueTraits for IDL dictionaries toImplArray() uses NativeValueTraits<T> and toV8NoInline() internally. The code generator should generate them to support sequence (or array) members of an IDL dictionary of which type an IDL dictionary. This CL also includes a fix for missing trace() calls for sequence and array members. BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -28 lines) Patch
M Source/bindings/scripts/v8_types.py View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.h View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.cpp View 3 chunks +15 lines, -2 lines 0 comments Download
M Source/bindings/tests/idls/core/TestDictionary.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 3 chunks +6 lines, -0 lines 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.h View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 5 chunks +29 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionaryDerived.h View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp View 3 chunks +15 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.h View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceEventInit.cpp View 3 chunks +15 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
bashi
PTAL? jrummell@ faced the problem when he was trying to implement https://codereview.chromium.org/759443005/
6 years ago (2014-11-26 01:29:35 UTC) #2
haraken
LGTM
6 years ago (2014-11-26 01:42:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759893002/1
6 years ago (2014-11-26 01:54:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/38499)
6 years ago (2014-11-26 04:12:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759893002/1
6 years ago (2014-11-26 05:17:58 UTC) #9
Jens Widell
LGTM
6 years ago (2014-11-26 06:40:52 UTC) #10
commit-bot: I haz the power
6 years ago (2014-11-26 08:27:07 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186008

Powered by Google App Engine
This is Rietveld 408576698