Source/bindings/tests/results/core/V8TestDictionaryDerived.h - Issue 759893002: IDL: Auto-generate NativeValueTraits for IDL dictionaries

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestDictionaryDerived.h

Issue 759893002: IDL: Auto-generate NativeValueTraits for IDL dictionaries (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestDictionary.cpp ('k') | Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestDictionaryDerived.h

diff --git a/Source/bindings/tests/results/core/V8TestDictionaryDerived.h b/Source/bindings/tests/results/core/V8TestDictionaryDerived.h

index 4ae5493ab2bf7344896f0d047c69eade1b664831..638b4c63a46a19856d80702ecd5f93cabde9ea6e 100644

--- a/Source/bindings/tests/results/core/V8TestDictionaryDerived.h

+++ b/Source/bindings/tests/results/core/V8TestDictionaryDerived.h

@@ -20,8 +20,8 @@ public:

static void toImpl(v8::Isolate*, v8::Handle<v8::Value>, TestDictionaryDerivedImplementedAs&, ExceptionState&);

};

-v8::Handle<v8::Value> toV8(TestDictionaryDerivedImplementedAs&, v8::Handle<v8::Object>, v8::Isolate*);

-void toV8TestDictionaryDerivedImplementedAs(TestDictionaryDerivedImplementedAs&, v8::Handle<v8::Object> dictionary, v8::Handle<v8::Object> creationContext, v8::Isolate*);

+v8::Handle<v8::Value> toV8(const TestDictionaryDerivedImplementedAs&, v8::Handle<v8::Object>, v8::Isolate*);

+void toV8TestDictionaryDerivedImplementedAs(const TestDictionaryDerivedImplementedAs&, v8::Handle<v8::Object> dictionary, v8::Handle<v8::Object> creationContext, v8::Isolate*);

template<class CallbackInfo>

inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestDictionaryDerivedImplementedAs& impl)

@@ -29,6 +29,11 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestDictionaryDer

v8SetReturnValue(callbackInfo, toV8(impl, callbackInfo.Holder(), callbackInfo.GetIsolate()));

}

+template <>

+struct NativeValueTraits<TestDictionaryDerivedImplementedAs> {

+ static TestDictionaryDerivedImplementedAs nativeValue(const v8::Handle<v8::Value>&, v8::Isolate*, ExceptionState&);

+};

} // namespace blink

#endif // V8TestDictionaryDerived_h