Issue 759763002: Fix DCHECK(gr_texture) when running test_sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 759763002: Fix DCHECK(gr_texture) when running test_sky (Closed)

Created:
6 years ago by abarth-chromium

Modified:
6 years ago

Reviewers:
ojan

CC:
ojan, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org, rafaelw, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix DCHECK(gr_texture) when running test_sky We shouldn't bother trying to draw a 0x0 sky::Layer. It makes Ganesh unhappy. R=ojan@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2998fc73626cef4f0b6fc96c316167b44bd37f95

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -4 lines)			Patch
M	mojo/gpu/gl_context_owner.h	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	mojo/skia/ganesh_surface.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/compositor/layer_host.cc	View	1 chunk	+10 lines, -0 lines	0 comments	Download
M	sky/compositor/resource_manager.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

6 years ago (2014-11-25 20:12:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2998fc73626cef4f0b6fc96c316167b44bd37f95 (presubmit successful).

Expand Messages | Collapse Messages