src/effects/SkAlphaThresholdFilter.cpp - Issue 759713002: Make all blending up to GrOptDrawState be handled by the xp/xp factory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkAlphaThresholdFilter.cpp

Issue 759713002: Make all blending up to GrOptDrawState be handled by the xp/xp factory. (Closed) Base URL: https://skia.googlesource.com/skia.git@xferFactorySolo

Patch Set: rebase Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/effects/SkAlphaThresholdFilter.cpp

diff --git a/src/effects/SkAlphaThresholdFilter.cpp b/src/effects/SkAlphaThresholdFilter.cpp

index 8908a6a9f5fd4328850733376c218a479fcc1d66..04504b5f8ba3715c9b7b906998eda0f4ebe2ff61 100644

--- a/src/effects/SkAlphaThresholdFilter.cpp

+++ b/src/effects/SkAlphaThresholdFilter.cpp

@@ -48,6 +48,7 @@ SkImageFilter* SkAlphaThresholdFilter::Create(const SkRegion& region,

#include "GrFragmentProcessor.h"

#include "GrInvariantOutput.h"

#include "GrTextureAccess.h"

+#include "effects/GrPorterDuffXferProcessor.h"

#include "SkGr.h"

@@ -283,7 +284,7 @@ bool SkAlphaThresholdFilterImpl::asFragmentProcessor(GrFragmentProcessor** fp,

{

GrContext::AutoRenderTarget art(context, maskTexture->asRenderTarget());

GrPaint grPaint;

- grPaint.setBlendFunc(kOne_GrBlendCoeff, kZero_GrBlendCoeff);

+ grPaint.setPorterDuffXPFactory(SkXfermode::kSrc_Mode);

SkRegion::Iterator iter(fRegion);

context->clear(NULL, 0x0, true, maskTexture->asRenderTarget());

« no previous file with comments | « src/core/SkXfermode.cpp ('k') | src/effects/SkBlurMaskFilter.cpp » ('j') | no next file with comments »