Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 759683004: ExecutableAccessorInfo::clear_setter should set a null foreign pointer (Closed)

Created:
6 years ago by dcarney
Modified:
6 years ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

ExecutableAccessorInfo::clear_setter should set a null foreign pointer R=jkummerow@chromium.org BUG=433458 LOG=N

Patch Set 1 #

Patch Set 2 : need write barrier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M src/objects-inl.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Jakob Kummerow
lgtm
6 years ago (2014-12-10 09:24:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759683004/1
6 years ago (2014-12-10 09:28:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759683004/20001
6 years ago (2014-12-10 09:48:44 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-10 10:18:07 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698