src/objects-inl.h - Issue 759683004: ExecutableAccessorInfo::clear_setter should set a null foreign pointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 759683004: ExecutableAccessorInfo::clear_setter should set a null foreign pointer (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: need write barrier Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index b36cff97bc1b2129ceeb1be41ecb5a223a6a88e3..4a7b200ff05fcda83e802f614cf035b44a6154ca 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -7022,7 +7022,9 @@ bool AccessorInfo::IsCompatibleReceiver(Object* receiver) {

void ExecutableAccessorInfo::clear_setter() {

- set_setter(GetIsolate()->heap()->undefined_value(), SKIP_WRITE_BARRIER);

+ set_setter(*GetIsolate()->factory()->NewForeign(

+ reinterpret_cast<v8::internal::Address>(

+ reinterpret_cast<intptr_t>(nullptr))));

}

« no previous file with comments | « no previous file | test/cctest/test-accessors.cc » ('j') | no next file with comments »