ONC: add support for non-utf-8 SSIDs

chromeos/network/onc/onc_validator_unittest.cc

Index: chromeos/network/onc/onc_validator_unittest.cc
diff --git a/chromeos/network/onc/onc_validator_unittest.cc b/chromeos/network/onc/onc_validator_unittest.cc
index c109ddc809bd754defccf2b96ae33e5642b78146..167374a9531c928e50210f86abd53779140554b8 100644
--- a/chromeos/network/onc/onc_validator_unittest.cc
+++ b/chromeos/network/onc/onc_validator_unittest.cc
@@ -152,6 +152,12 @@ INSTANTIATE_TEST_CASE_P(
         OncParams("managed_toplevel_l2tpipsec.onc",
                   &kToplevelConfigurationSignature,
                   true),
+        OncParams("toplevel_wifi_hexssid.onc",
+                  &kToplevelConfigurationSignature,
+                  false),
+        OncParams("toplevel_wifi_hexssid.onc",

[pneubeck (no reviews), 2014/11/26 10:15:34]

I wouldn't test both managed=true and =false if we know already that the code
does not depend on it.

Instead ensure that the different valid cases are covered:
  SSID only
  HexSSID only
  both present and consistent

[cschuet (SLOW), 2014/11/27 11:03:58]

Done.

+                  &kToplevelConfigurationSignature,
+                  true),
         OncParams("toplevel_wifi_wpa_psk.onc",
                   &kToplevelConfigurationSignature,
                   false),
@@ -449,6 +455,14 @@ INSTANTIATE_TEST_CASE_P(
                                  &kNetworkConfigurationSignature,
                                  false),
                        ExpectBothNotValid("", "")),
+        std::make_pair(OncParams("network-wifi-invalid-hexssid",

[pneubeck (no reviews), 2014/11/26 10:15:34]

nit: you could also test for invalid length

[cschuet (SLOW), 2014/11/27 11:03:58]

Done.

+                                 &kNetworkConfigurationSignature,
+                                 false),
+                       ExpectBothNotValid("", "")),
+        std::make_pair(OncParams("network-wifi-ssid-and-hexssid-inconsistent",
+                                 &kNetworkConfigurationSignature,
+                                 false),
+                       ExpectBothNotValid("", "")),
         std::make_pair(OncParams("managed-network-unknown-value",
                                  &kNetworkConfigurationSignature,
                                  true),