Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chromeos/network/onc/onc_validator_unittest.cc

Issue 759663004: ONC: add support for non-utf-8 SSIDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« chromeos/network/onc/onc_validator.cc ('K') | « chromeos/network/onc/onc_validator.cc ('k') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('j') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/onc/onc_validator.h" 5 #include "chromeos/network/onc/onc_validator.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 134 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 true), 145 true),
146 // Check that at least one configuration is accepted for 146 // Check that at least one configuration is accepted for
147 // device policies. 147 // device policies.
148 OncParams("managed_toplevel_wifi_peap.onc", 148 OncParams("managed_toplevel_wifi_peap.onc",
149 &kToplevelConfigurationSignature, 149 &kToplevelConfigurationSignature,
150 true, 150 true,
151 ::onc::ONC_SOURCE_DEVICE_POLICY), 151 ::onc::ONC_SOURCE_DEVICE_POLICY),
152 OncParams("managed_toplevel_l2tpipsec.onc", 152 OncParams("managed_toplevel_l2tpipsec.onc",
153 &kToplevelConfigurationSignature, 153 &kToplevelConfigurationSignature,
154 true), 154 true),
155 OncParams("toplevel_wifi_hexssid.onc",
156 &kToplevelConfigurationSignature,
157 false),
158 OncParams("toplevel_wifi_hexssid.onc",
pneubeck (no reviews) 2014/11/26 10:15:34 I wouldn't test both managed=true and =false if we
cschuet (SLOW) 2014/11/27 11:03:58 Done.
159 &kToplevelConfigurationSignature,
160 true),
155 OncParams("toplevel_wifi_wpa_psk.onc", 161 OncParams("toplevel_wifi_wpa_psk.onc",
156 &kToplevelConfigurationSignature, 162 &kToplevelConfigurationSignature,
157 false), 163 false),
158 OncParams("toplevel_wifi_wep_proxy.onc", 164 OncParams("toplevel_wifi_wep_proxy.onc",
159 &kToplevelConfigurationSignature, 165 &kToplevelConfigurationSignature,
160 false), 166 false),
161 OncParams("toplevel_wifi_leap.onc", 167 OncParams("toplevel_wifi_leap.onc",
162 &kToplevelConfigurationSignature, 168 &kToplevelConfigurationSignature,
163 false), 169 false),
164 OncParams("toplevel_wifi_eap_clientcert_with_cert_pems.onc", 170 OncParams("toplevel_wifi_eap_clientcert_with_cert_pems.onc",
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
442 448
443 // Strict and liberal validator return both INVALID. 449 // Strict and liberal validator return both INVALID.
444 INSTANTIATE_TEST_CASE_P( 450 INSTANTIATE_TEST_CASE_P(
445 StrictAndLiberalInvalid, 451 StrictAndLiberalInvalid,
446 ONCValidatorTestRepairable, 452 ONCValidatorTestRepairable,
447 ::testing::Values( 453 ::testing::Values(
448 std::make_pair(OncParams("network-unknown-value", 454 std::make_pair(OncParams("network-unknown-value",
449 &kNetworkConfigurationSignature, 455 &kNetworkConfigurationSignature,
450 false), 456 false),
451 ExpectBothNotValid("", "")), 457 ExpectBothNotValid("", "")),
458 std::make_pair(OncParams("network-wifi-invalid-hexssid",
pneubeck (no reviews) 2014/11/26 10:15:34 nit: you could also test for invalid length
cschuet (SLOW) 2014/11/27 11:03:58 Done.
459 &kNetworkConfigurationSignature,
460 false),
461 ExpectBothNotValid("", "")),
462 std::make_pair(OncParams("network-wifi-ssid-and-hexssid-inconsistent",
463 &kNetworkConfigurationSignature,
464 false),
465 ExpectBothNotValid("", "")),
452 std::make_pair(OncParams("managed-network-unknown-value", 466 std::make_pair(OncParams("managed-network-unknown-value",
453 &kNetworkConfigurationSignature, 467 &kNetworkConfigurationSignature,
454 true), 468 true),
455 ExpectBothNotValid("", "")), 469 ExpectBothNotValid("", "")),
456 std::make_pair(OncParams("network-value-out-of-range", 470 std::make_pair(OncParams("network-value-out-of-range",
457 &kNetworkConfigurationSignature, 471 &kNetworkConfigurationSignature,
458 false), 472 false),
459 ExpectBothNotValid("", "")), 473 ExpectBothNotValid("", "")),
460 std::make_pair( 474 std::make_pair(
461 OncParams("ipsec-with-psk-and-cacert", &kIPsecSignature, false), 475 OncParams("ipsec-with-psk-and-cacert", &kIPsecSignature, false),
(...skipping 30 matching lines...) Expand all
492 true, 506 true,
493 ::onc::ONC_SOURCE_DEVICE_POLICY), 507 ::onc::ONC_SOURCE_DEVICE_POLICY),
494 ExpectBothNotValid("", "")), 508 ExpectBothNotValid("", "")),
495 std::make_pair(OncParams("openvpn-invalid-verify-x509-type", 509 std::make_pair(OncParams("openvpn-invalid-verify-x509-type",
496 &kNetworkConfigurationSignature, 510 &kNetworkConfigurationSignature,
497 false), 511 false),
498 ExpectBothNotValid("", "")))); 512 ExpectBothNotValid("", ""))));
499 513
500 } // namespace onc 514 } // namespace onc
501 } // namespace chromeos 515 } // namespace chromeos
OLDNEW
« chromeos/network/onc/onc_validator.cc ('K') | « chromeos/network/onc/onc_validator.cc ('k') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('j') | chromeos/test/data/network/invalid_settings_with_repairs.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698