ONC: add support for non-utf-8 SSIDs

chromeos/network/onc/onc_utils.h

Index: chromeos/network/onc/onc_utils.h
diff --git a/chromeos/network/onc/onc_utils.h b/chromeos/network/onc/onc_utils.h
index c31cd2e4b4b75e5236942c58e5c58e91390c9eb0..c37acbf3c55b1ea896261e283a09d3bb87c6928e 100644
--- a/chromeos/network/onc/onc_utils.h
+++ b/chromeos/network/onc/onc_utils.h
@@ -83,6 +83,11 @@ CHROMEOS_EXPORT void ExpandStringsInNetworks(
     const StringSubstitution& substitution,
     base::ListValue* network_configs);
 
+// If the UTF-8 encoded SSID field is set, but HexSSID is not, this function

[pneubeck (no reviews), 2014/11/26 10:15:34]

The encoding _in_ the SSID field doesn't matter. The semantics of the field are
that we _use it with the UTF-8 encoding_.

I would change the comment to:

If the SSID field is set, but HexSSID is not, converts the contents of the SSID
field to UTF-8 encoding, creates the hex representation and assigns the result
to HexSSID.

[cschuet (SLOW), 2014/11/27 11:03:58]

Done.

+// converts the contents of the SSID field to a hex representation and assigns
+// the value to HexSSID.
+CHROMEOS_EXPORT void FillInHexSSIDField(base::DictionaryValue* wifi_fields);
+
 // Creates a copy of |onc_object| with all values of sensitive fields replaced
 // by |mask|. To find sensitive fields, signature and field name are checked
 // with the function FieldIsCredential().