ONC: add support for non-utf-8 SSIDs

chromeos/network/onc/onc_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_ONC_ONC_UTILS_H_
 #define CHROMEOS_NETWORK_ONC_ONC_UTILS_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 65 matching lines @@
     const OncValueSignature& signature,
     const StringSubstitution& substitution,
     base::DictionaryValue* onc_object);
 
 // Replaces expandable fields in the networks of |network_configs|, which must
 // be a list of ONC NetworkConfigurations. See ExpandStringsInOncObject above.
 CHROMEOS_EXPORT void ExpandStringsInNetworks(
     const StringSubstitution& substitution,
     base::ListValue* network_configs);
 
+// If the UTF-8 encoded SSID field is set, but HexSSID is not, this function

[pneubeck (no reviews), 2014/11/26 10:15:34]

The encoding _in_ the SSID field doesn't matter. The semantics of the field are
that we _use it with the UTF-8 encoding_.

I would change the comment to:

If the SSID field is set, but HexSSID is not, converts the contents of the SSID
field to UTF-8 encoding, creates the hex representation and assigns the result
to HexSSID.

[cschuet (SLOW), 2014/11/27 11:03:58]

Done.

+// converts the contents of the SSID field to a hex representation and assigns
+// the value to HexSSID.
+CHROMEOS_EXPORT void FillInHexSSIDField(base::DictionaryValue* wifi_fields);
+
 // Creates a copy of |onc_object| with all values of sensitive fields replaced
 // by |mask|. To find sensitive fields, signature and field name are checked
 // with the function FieldIsCredential().
 CHROMEOS_EXPORT scoped_ptr<base::DictionaryValue> MaskCredentialsInOncObject(
     const OncValueSignature& signature,
     const base::DictionaryValue& onc_object,
     const std::string& mask);
 
 // Decrypts |onc_blob| with |passphrase| if necessary. Clears |network_configs|,
 // |global_network_config| and |certificates| and fills them with the validated
@@ skipping 35 matching lines @@
     const std::string& type);
 
 // Returns true if |property_key| is a recommended value in the ONC dictionary.
 CHROMEOS_EXPORT bool IsRecommendedValue(const base::DictionaryValue* onc,
                                         const std::string& property_key);
 
 }  // namespace onc
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_ONC_ONC_UTILS_H_