Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 759553002: [Blink-in-JS] 'Import' function to load sub-modules and other resources for private scripts (Part-2) (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Blink-in-JS] 'Import' function to load sub-modules and other resources for private scripts (Part-2) This CL introduces 'Import' function to load sub-modules for the private scripts. This helps to break down larger script modules in manageable script chunks. The 'Import' function has been defined in CL Part 3. Part 1: https://codereview.chromium.org/755883004 Part 3: https://codereview.chromium.org/757963002 TBR=jochen@chromium.org Committed: https://crrev.com/43ac0dc7415aa60756bc4a6b75b555d714565c45 Cr-Commit-Position: refs/heads/master@{#306541}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Corrected the include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/child/blink_platform_impl.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
vivekg
This is chromium side change required for the resource file to be picked up.
6 years ago (2014-11-25 07:04:02 UTC) #2
vivekg
PTAL, thanks!
6 years ago (2014-11-25 09:25:55 UTC) #5
haraken
LGTM
6 years ago (2014-11-25 09:26:55 UTC) #6
vivekg
On 2014/11/25 at 09:26:55, haraken wrote: > LGTM @haraken, thank you! I guess this also ...
6 years ago (2014-11-27 08:31:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759553002/60001
6 years ago (2014-12-03 01:31:40 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-12-03 03:47:18 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-03 03:48:04 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/43ac0dc7415aa60756bc4a6b75b555d714565c45
Cr-Commit-Position: refs/heads/master@{#306541}

Powered by Google App Engine
This is Rietveld 408576698