Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 755883004: [Blink-in-JS] 'Import' function to load sub-modules and other resources for private scripts (Part-1) (Closed)

Created:
6 years ago by vivekg_samsung
Modified:
6 years ago
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Blink-in-JS] 'Import' function to load sub-modules and other resources for private scripts (Part-1) This CL introduces 'Import' function to load sub-modules for the private scripts. This helps to break down larger script modules in manageable script chunks. The 'Import' function has been defined in CL Part 3. Part 2: https://codereview.chromium.org/759553002 Part 3: https://codereview.chromium.org/757963002 TBR=jochen@chromium.org R=haraken@chromium.org, jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186309

Patch Set 1 #

Patch Set 2 : Corrected include order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
A Source/core/xml/DocumentXMLTreeViewer.css View 1 chunk +53 lines, -0 lines 0 comments Download
M public/blink_resources.grd View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
vivekg
PTAL, thanks!
6 years ago (2014-11-25 09:22:00 UTC) #2
haraken
LGTM
6 years ago (2014-11-25 09:26:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755883004/20001
6 years ago (2014-11-25 09:38:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/20663)
6 years ago (2014-11-25 09:43:59 UTC) #7
vivekg
Missing OWNERs lgtm. @jochen, can you please take a look?
6 years ago (2014-11-25 12:15:36 UTC) #8
vivekg
On 2014/11/25 at 12:15:36, vivekg_ wrote: > Missing OWNERs lgtm. @jochen, can you please take ...
6 years ago (2014-11-27 06:55:25 UTC) #9
vivekg
ping! :)
6 years ago (2014-12-01 11:27:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/755883004/20001
6 years ago (2014-12-02 16:04:22 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-02 16:34:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186309

Powered by Google App Engine
This is Rietveld 408576698