Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 759503002: Remove unneeded #define in ref_counted.h (Closed)

Created:
6 years ago by dcheng
Modified:
6 years ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded #define in ref_counted.h Now that the implicit conversion to T* can be removed, the preprocessor define DISABLE_SCOPED_REFPTR_CONVERSION_OPERATOR is no longer needed. BUG=110610 Committed: https://crrev.com/e699b92b064e51a5ffa57debbd5e2e260558b32d Cr-Commit-Position: refs/heads/master@{#305591}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Bug URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M base/memory/ref_counted.h View 1 6 chunks +2 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dcheng
6 years ago (2014-11-25 02:55:14 UTC) #2
Nico
lgtm! https://codereview.chromium.org/759503002/diff/1/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/759503002/diff/1/base/memory/ref_counted.h#newcode380 base/memory/ref_counted.h:380: // Temporary operator overloads to facilitate the transition... ...
6 years ago (2014-11-25 02:59:10 UTC) #3
dcheng
https://codereview.chromium.org/759503002/diff/1/base/memory/ref_counted.h File base/memory/ref_counted.h (right): https://codereview.chromium.org/759503002/diff/1/base/memory/ref_counted.h#newcode380 base/memory/ref_counted.h:380: // Temporary operator overloads to facilitate the transition... On ...
6 years ago (2014-11-25 03:00:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/759503002/20001
6 years ago (2014-11-25 03:01:36 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-11-25 05:41:03 UTC) #7
commit-bot: I haz the power
6 years ago (2014-11-25 05:42:31 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e699b92b064e51a5ffa57debbd5e2e260558b32d
Cr-Commit-Position: refs/heads/master@{#305591}

Powered by Google App Engine
This is Rietveld 408576698