Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1965)

Unified Diff: base/memory/ref_counted.h

Issue 759503002: Remove unneeded #define in ref_counted.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Bug URL Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/memory/ref_counted.h
diff --git a/base/memory/ref_counted.h b/base/memory/ref_counted.h
index e05f45dc8a2d5dc3a765f466a8ab6eefd8694357..0fb7447b999e744e39ff24336005bcbd593172eb 100644
--- a/base/memory/ref_counted.h
+++ b/base/memory/ref_counted.h
@@ -17,10 +17,6 @@
#include "base/threading/thread_collision_warner.h"
#include "build/build_config.h"
-#if defined(OS_LINUX) || defined(OS_MACOSX) || defined(OS_IOS) || defined(OS_ANDROID) || defined(OS_WIN)
-#define DISABLE_SCOPED_REFPTR_CONVERSION_OPERATOR
-#endif
-
namespace base {
namespace subtle {
@@ -297,12 +293,6 @@ class scoped_refptr {
T* get() const { return ptr_; }
-#if !defined(DISABLE_SCOPED_REFPTR_CONVERSION_OPERATOR)
- // Allow scoped_refptr<C> to be used in boolean expression
- // and comparison operations.
- operator T*() const { return ptr_; }
-#endif
-
T& operator*() const {
assert(ptr_ != NULL);
return *ptr_;
@@ -343,7 +333,6 @@ class scoped_refptr {
swap(&r.ptr_);
}
-#if defined(DISABLE_SCOPED_REFPTR_CONVERSION_OPERATOR)
template <typename U>
bool operator==(const scoped_refptr<U>& rhs) const {
return ptr_ == rhs.get();
@@ -358,7 +347,6 @@ class scoped_refptr {
bool operator<(const scoped_refptr<U>& rhs) const {
return ptr_ < rhs.get();
}
-#endif
protected:
T* ptr_;
@@ -389,8 +377,8 @@ scoped_refptr<T> make_scoped_refptr(T* t) {
return scoped_refptr<T>(t);
}
-#if defined(DISABLE_SCOPED_REFPTR_CONVERSION_OPERATOR)
-// Temporary operator overloads to facilitate the transition...
+// Temporary operator overloads to facilitate the transition. See
+// https://crbug.com/110610.
template <typename T, typename U>
bool operator==(const scoped_refptr<T>& lhs, const U* rhs) {
return lhs.get() == rhs;
@@ -415,6 +403,5 @@ template <typename T>
std::ostream& operator<<(std::ostream& out, const scoped_refptr<T>& p) {
return out << p.get();
}
-#endif // defined(DISABLE_SCOPED_REFPTR_CONVERSION_OPERATOR)
#endif // BASE_MEMORY_REF_COUNTED_H_
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698