Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: Source/core/paint/ObjectPainter.h

Issue 759373002: Better handling border color style decoration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changing the test per reviewer's request. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/paint/ObjectPainter.h
diff --git a/Source/core/paint/ObjectPainter.h b/Source/core/paint/ObjectPainter.h
index a66e033b87b950eb38b64ac484465a1e2cc3c311..5b682a7532d9b2a34cf2812f95417f4b5970a09f 100644
--- a/Source/core/paint/ObjectPainter.h
+++ b/Source/core/paint/ObjectPainter.h
@@ -33,6 +33,7 @@ public:
BoxSide, Color, EBorderStyle, int adjacentWidth1, int adjacentWidth2, bool antialias);
static void drawSolidBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,
BoxSide, Color, int adjacentWidth1, int adjacentWidth2, bool antialias);
+ static void modifyBorderColorForStyleIfNeeded(const EBorderStyle&, const BoxSide&, Color&);
chrishtr 2014/12/01 22:51:31 Should be private, not public.
Savago 2014/12/02 01:02:39 It makes sense, but observe that all the static cl
pdr. 2014/12/02 02:55:49 This was a mistake, lets not be consistently wrong
chrishtr 2014/12/02 03:17:51 Some of those are public because they are used fro
private:
RenderObject& m_renderObject;

Powered by Google App Engine
This is Rietveld 408576698