Better handling border color style decoration

Source/core/paint/ObjectPainter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ObjectPainter_h
 #define ObjectPainter_h
 
 #include "core/rendering/style/RenderStyleConstants.h"
 
 namespace blink {
@@ skipping 15 matching lines @@
 
     static void drawLineForBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2, BoxSide, Color, EBorderStyle, int adjbw1, int adjbw2, bool antialias = false);
     static void drawDashedOrDottedBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,
         BoxSide, Color, int thickness, EBorderStyle, bool antialias);
     static void drawDoubleBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,
         int length, BoxSide, Color, int thickness, int adjacentWidth1, int adjacentWidth2, bool antialias);
     static void drawRidgeOrGrooveBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,
         BoxSide, Color, EBorderStyle, int adjacentWidth1, int adjacentWidth2, bool antialias);
     static void drawSolidBoxSide(GraphicsContext*, int x1, int y1, int x2, int y2,
         BoxSide, Color, int adjacentWidth1, int adjacentWidth2, bool antialias);
+    static void modifyBorderColorForStyleIfNeeded(const EBorderStyle&, const BoxSide&, Color&);

[chrishtr, 2014/12/01 22:51:31]

Should be private, not public.

[Savago, 2014/12/02 01:02:39]

It makes sense, but observe that all the static class member functions in
ObjectPainter are public too (makes sense to follow the same style to maintain
consistency).

[pdr., 2014/12/02 02:55:49]

This was a mistake, lets not be consistently wrong :)

[chrishtr, 2014/12/02 03:17:51]

Some of those are public because they are used from another class (e.g.
drawLineForBoxSide() ). For the ones that do not need to be public, please make
them private
while you are at it.

 private:
 
     RenderObject& m_renderObject;
 };
 
 } // namespace blink
 
 #endif