Fix Windows build after https://codereview.chromium.org/757703002/

Fix Windows build after https://codereview.chromium.org/757703002/

R=abarth@chromium.org, hansmuller@chromium.org, jam@chromium.org, jamesr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/aa6c5ff8a309a2217978bea84ff016a63dd41b26

[abarth-chromium, 2014-11-25 04:17:54]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2014-11-25 04:17:55]

lgtm

[scottmg, 2014-11-25 04:48:16]

Committed patchset #1 (id:1) manually as
aa6c5ff8a309a2217978bea84ff016a63dd41b26 (presubmit successful).

[hansmuller, 2014-11-25 15:31:29]

On 2014/11/25 04:48:16, scottmg wrote:
> Committed patchset #1 (id:1) manually as
> aa6c5ff8a309a2217978bea84ff016a63dd41b26 (presubmit successful).

Thanks for fixing this!

[jamesr, 2014-11-25 18:27:55]

https://codereview.chromium.org/758823002/diff/1/services/js/js_app_shell.cc
File services/js/js_app_shell.cc (right):

https://codereview.chromium.org/758823002/diff/1/services/js/js_app_shell.cc#...
services/js/js_app_shell.cc:17: return gin::CreateHandle(isolate, new
JSAppShell(js_app));
do you have any idea how this compiled before?  'isolate' and 'JSAppShell' are
not in the 'gin' namespace, so I don't think ADL would apply here.  What is
going on?

[jamesr, 2014-11-25 18:29:19]

https://codereview.chromium.org/758823002/diff/1/services/js/js_app_shell.cc
File services/js/js_app_shell.cc (right):

https://codereview.chromium.org/758823002/diff/1/services/js/js_app_shell.cc#...
services/js/js_app_shell.cc:17: return gin::CreateHandle(isolate, new
JSAppShell(js_app));
On 2014/11/25 18:27:55, jamesr wrote:
> do you have any idea how this compiled before?  'isolate' and 'JSAppShell' are
> not in the 'gin' namespace, so I don't think ADL would apply here.  What is
> going on?

Actually, JSAppShell inherits from gin::Wrappable<>, so maybe that's the trick?

/me will try some things

[scottmg, 2014-11-25 20:19:42]

On 2014/11/25 18:29:19, jamesr wrote:
> https://codereview.chromium.org/758823002/diff/1/services/js/js_app_shell.cc
> File services/js/js_app_shell.cc (right):
> 
>
https://codereview.chromium.org/758823002/diff/1/services/js/js_app_shell.cc#...
> services/js/js_app_shell.cc:17: return gin::CreateHandle(isolate, new
> JSAppShell(js_app));
> On 2014/11/25 18:27:55, jamesr wrote:
> > do you have any idea how this compiled before?  'isolate' and 'JSAppShell'
are
> > not in the 'gin' namespace, so I don't think ADL would apply here.  What is
> > going on?
> 
> Actually, JSAppShell inherits from gin::Wrappable<>, so maybe that's the
trick?
> 
> /me will try some things

Nico suggests this probably is an ADL bug. Repro and bug filed against VS here:
https://connect.microsoft.com/VisualStudio/feedback/details/1039545/incorrect...

[scottmg, 2015-01-12 19:32:01]

This is marked fixed for the next major revision of VS (i.e. VS2015).