services/js/js_app_shell.cc - Issue 758823002: Fix Windows build after https://codereview.chromium.org/757703002/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/js/js_app_shell.cc

Issue 758823002: Fix Windows build after https://codereview.chromium.org/757703002/ (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: services/js/js_app_shell.cc

diff --git a/services/js/js_app_shell.cc b/services/js/js_app_shell.cc

index 448ba3d62c0b0014b41e925a4a3ac9b0d694ae08..27011ab5a9552e5a2d97a82c8b7ab5b2698b4d28 100644

--- a/services/js/js_app_shell.cc

+++ b/services/js/js_app_shell.cc

@@ -14,7 +14,7 @@ gin::WrapperInfo JSAppShell::kWrapperInfo = {gin::kEmbedderNativeGin};

gin::Handle<JSAppShell> JSAppShell::Create(v8::Isolate* isolate,

JSApp* js_app) {

- return CreateHandle(isolate, new JSAppShell(js_app));

+ return gin::CreateHandle(isolate, new JSAppShell(js_app));

jamesr 2014/11/25 18:27:55 do you have any idea how this compiled before? 'i

jamesr 2014/11/25 18:29:19 Actually, JSAppShell inherits from gin::Wrappable<

}

JSAppShell::JSAppShell(JSApp* js_app) : js_app_(js_app) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »