|
|
Created:
6 years ago by sof Modified:
6 years ago Reviewers:
Nate Chapin, Mike West, dcheng CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Project:
blink Visibility:
Public. |
DescriptionFix MEMORY_CACHE_STATS compilation.
Update MemoryCache::dumpLRULists() to work over the current representation
of MemoryCacheEntry and its attached resource.
This debug-only method wasn't updated as part of https://codereview.chromium.org/174523002 (r168851.)
R=dcheng,mkwst
BUG=
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186017
Patch Set 1 #Patch Set 2 : rebased #
Created: 6 years ago
Messages
Total messages: 17 (5 generated)
sigbjornf@opera.com changed reviewers: + dcheng@chromium.org, japhet@chromium.org
Please take a look.
sigbjornf@opera.com changed reviewers: + mkwst@chromium.org
+mkwst
Is there a bug? What changed? Sorry, I don't have a lot of context to review this change in.
On 2014/11/25 07:35:47, dcheng wrote: > Is there a bug? What changed? Sorry, I don't have a lot of context to review > this change in. This debug-only code broke a while ago, r170905 induced, just tidying up.
lgtm
(Perhaps include a link to the bug associated with the revision that broke this)
Same comments from me. If you clarify in the CL, then LGTM.
On 2014/11/25 09:46:34, dcheng wrote: > (Perhaps include a link to the bug associated with the revision that broke this) Thanks, good suggestion - r168851 it was.
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758673002/1
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for Source/core/fetch/MemoryCache.cpp: While running svn add Source/core/fetch --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; svn: 'Source/core' is not a working copy Patch: Source/core/fetch/MemoryCache.cpp Index: Source/core/fetch/MemoryCache.cpp diff --git a/Source/core/fetch/MemoryCache.cpp b/Source/core/fetch/MemoryCache.cpp index 52603e3d0eb16583fbb3502fa2953b7c7017b3be..ca3a5a8581854b25a42d9359d03a2d4fdd349b32 100644 --- a/Source/core/fetch/MemoryCache.cpp +++ b/Source/core/fetch/MemoryCache.cpp @@ -838,13 +838,13 @@ void MemoryCache::dumpLRULists(bool includeLive) const int size = m_allResources.size(); for (int i = size - 1; i >= 0; i--) { printf("\n\nList %d: ", i); - Resource* current = m_allResources[i].m_tail; + MemoryCacheEntry* current = m_allResources[i].m_tail; while (current) { - Resource* prev = current->m_prevInAllResourcesList; - if (includeLive || !current->hasClients()) - printf("(%.1fK, %.1fK, %uA, %dR, %d, %d); ", current->decodedSize() / 1024.0f, (current->encodedSize() + current->overheadSize()) / 1024.0f, current->accessCount(), current->hasClients(), current->isPurgeable(), current->wasPurged()); + ResourcePtr<Resource> currentResource = current->m_resource; + if (includeLive || !currentResource->hasClients()) + printf("(%.1fK, %.1fK, %uA, %dR, %d, %d); ", currentResource->decodedSize() / 1024.0f, (currentResource->encodedSize() + currentResource->overheadSize()) / 1024.0f, current->m_accessCount, currentResource->hasClients(), currentResource->isPurgeable(), currentResource->wasPurged()); - current = prev; + current = current->m_previousInAllResourcesList; } } }
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758673002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=186017 |