Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 758673002: Fix MEMORY_CACHE_STATS compilation. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
CC:
blink-reviews, gavinp+loader_chromium.org, Nate Chapin, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Fix MEMORY_CACHE_STATS compilation. Update MemoryCache::dumpLRULists() to work over the current representation of MemoryCacheEntry and its attached resource. This debug-only method wasn't updated as part of https://codereview.chromium.org/174523002 (r168851.) R=dcheng,mkwst BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186017

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M Source/core/fetch/MemoryCache.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (5 generated)
sof
Please take a look.
6 years ago (2014-11-24 21:41:16 UTC) #2
sof
+mkwst
6 years ago (2014-11-25 07:20:38 UTC) #4
dcheng
Is there a bug? What changed? Sorry, I don't have a lot of context to ...
6 years ago (2014-11-25 07:35:47 UTC) #5
sof
On 2014/11/25 07:35:47, dcheng wrote: > Is there a bug? What changed? Sorry, I don't ...
6 years ago (2014-11-25 09:44:43 UTC) #6
dcheng
lgtm
6 years ago (2014-11-25 09:46:09 UTC) #7
dcheng
(Perhaps include a link to the bug associated with the revision that broke this)
6 years ago (2014-11-25 09:46:34 UTC) #8
Mike West
Same comments from me. If you clarify in the CL, then LGTM.
6 years ago (2014-11-25 10:31:14 UTC) #9
sof
On 2014/11/25 09:46:34, dcheng wrote: > (Perhaps include a link to the bug associated with ...
6 years ago (2014-11-25 13:34:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758673002/1
6 years ago (2014-11-25 13:52:23 UTC) #12
commit-bot: I haz the power
Failed to apply patch for Source/core/fetch/MemoryCache.cpp: While running svn add Source/core/fetch --force --config-dir /b/infra_internal/commit_queue/subversion_config --non-interactive; ...
6 years ago (2014-11-25 14:56:18 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758673002/20001
6 years ago (2014-11-26 07:04:42 UTC) #16
commit-bot: I haz the power
6 years ago (2014-11-26 09:29:34 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186017

Powered by Google App Engine
This is Rietveld 408576698