Reland "Move MemoryCache implementation details out of Resource"

Reland "Move MemoryCache implementation details out of Resource"

Currently, the linked-list next/previous pointers for the LRU lists in MemoryCache actually live on Resource. Move them to a new MemoryCacheEntry object that is part of MemoryCache. There are probably more possibilities for changes of this kind.

This change exposed some issues in tests that excercise the MemoryCache directly. Specifically, they add() multiple Resources with the same url, which clobber each other in the MemoryCache::m_resources HashMap. Add an assert to MemoryCache::add() that we are not overwriting existing entries, and give Resources urls in tests where there are conflicts.

Compared to original attempt: Remove some cases that should only ever be hit if the LRULists are already mangled. Add some ASSERTs, and RELEASE_ASSERT !inCache() in Resource's destructor, since if inCache() is true, we're going to use-after-free in MemoryCache later.

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168851

[Nate Chapin, 2014-02-21 21:53:16]

Patchset 1 is what was originally landed.

[Nate Chapin, 2014-02-27 17:58:35]

On 2014/02/21 21:53:16, Nate Chapin wrote:
> Patchset 1 is what was originally landed.

ping

[abarth-chromium, 2014-02-28 06:31:09]

LGTM

Sorry, I didn't realize you were looking for a new review.  Thanks for uploading
the old patch so I could look at the interpatch diff.

https://codereview.chromium.org/174523002/diff/30001/Source/core/fetch/Resour...
File Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/174523002/diff/30001/Source/core/fetch/Resour...
Source/core/fetch/Resource.cpp:144: RELEASE_ASSERT(!inCache());
:)

[Nate Chapin, 2014-03-10 16:07:50]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-03-10 16:18:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/174523002/30001

[commit-bot: I haz the power, 2014-03-10 16:55:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-10 16:55:17]

Try jobs failed on following builders: linux_blink_rel, mac_blink_compile,
mac_blink_rel, win_blink_compile

[Nate Chapin, 2014-03-10 17:23:27]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-03-10 17:28:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/japhet@chromium.org/174523002/190001

[commit-bot: I haz the power, 2014-03-10 18:49:23]

Change committed as 168851