Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 758623002: Remove didNotifySubtreeInsertionsToDocument. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove didNotifySubtreeInsertionsToDocument. This hook existed because some elements wanted to run script inside ::insertedInto, but that wasn't a safe time. Now nothing can run script inside there so we don't need this extra hook. HTMLStyleElement's usage of this hook is not clear, but it seems like it might have related to a pre-lazy attach bug. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b07d6795a37cac9a5e957fe6b28b68afb224faa6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -89 lines) Patch
M sky/engine/core/dom/ContainerNode.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/ContainerNode.cpp View 2 chunks +4 lines, -12 lines 0 comments Download
M sky/engine/core/dom/Element.h View 3 chunks +2 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Node.h View 1 chunk +1 line, -29 lines 0 comments Download
M sky/engine/core/dom/shadow/InsertionPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/shadow/InsertionPoint.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/shadow/ShadowRoot.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M sky/engine/core/html/HTMLIFrameElement.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLIFrameElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/html/HTMLImportElement.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLImportElement.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/engine/core/html/HTMLStyleElement.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/html/HTMLStyleElement.cpp View 2 chunks +9 lines, -11 lines 0 comments Download
M sky/engine/core/html/HTMLTitleElement.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLTitleElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
6 years ago (2014-11-24 20:25:29 UTC) #2
esprehn
6 years ago (2014-11-25 07:53:47 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b07d6795a37cac9a5e957fe6b28b68afb224faa6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698