Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: sky/engine/core/dom/shadow/ShadowRoot.cpp

Issue 758623002: Remove didNotifySubtreeInsertionsToDocument. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/shadow/ShadowRoot.h ('k') | sky/engine/core/html/HTMLIFrameElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/shadow/ShadowRoot.cpp
diff --git a/sky/engine/core/dom/shadow/ShadowRoot.cpp b/sky/engine/core/dom/shadow/ShadowRoot.cpp
index 1e6eb95c1871dd38dd7eba1119dadfb905e3ee03..df5ee773e4e3179976299c6ddf6a5c3e26208249 100644
--- a/sky/engine/core/dom/shadow/ShadowRoot.cpp
+++ b/sky/engine/core/dom/shadow/ShadowRoot.cpp
@@ -126,25 +126,23 @@ void ShadowRoot::recalcStyle(StyleRecalcChange change)
clearChildNeedsStyleRecalc();
}
-Node::InsertionNotificationRequest ShadowRoot::insertedInto(ContainerNode* insertionPoint)
+void ShadowRoot::insertedInto(ContainerNode* insertionPoint)
{
DocumentFragment::insertedInto(insertionPoint);
if (!insertionPoint->inDocument() || !isOldest())
- return InsertionDone;
+ return;
// FIXME: When parsing <video controls>, insertedInto() is called many times without invoking removedFrom.
// For now, we check m_registeredWithParentShadowroot. We would like to ASSERT(!m_registeredShadowRoot) here.
// https://bugs.webkit.org/show_bug.cig?id=101316
if (m_registeredWithParentShadowRoot)
- return InsertionDone;
+ return;
if (ShadowRoot* root = host()->containingShadowRoot()) {
root->addChildShadowRoot();
m_registeredWithParentShadowRoot = true;
}
-
- return InsertionDone;
}
void ShadowRoot::removedFrom(ContainerNode* insertionPoint)
« no previous file with comments | « sky/engine/core/dom/shadow/ShadowRoot.h ('k') | sky/engine/core/html/HTMLIFrameElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698