Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 75823002: Add Blink-side flag for enabling/disabling layer squashing. (Closed)

Created:
7 years, 1 month ago by shawnsingh
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, arv+blink, bemjb+rendering_chromium.org, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, blink-layers+watch_chromium.org, dglazkov+blink, Inactive, jchaffraix+rendering, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Add Blink-side flag for enabling/disabling layer squashing. default is off. BUG=315317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162497

Patch Set 1 #

Patch Set 2 : fixed unwanted local testing hacks #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M Source/core/page/Settings.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/page/Settings.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerCompositor.h View 1 chunk +1 line, -0 lines 0 comments Download
Source/core/rendering/RenderLayerCompositor.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
Source/core/testing/InternalSettings.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.cpp View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M Source/core/testing/InternalSettings.idl View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
Source/web/WebSettingsImpl.cpp View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
public/web/WebSettings.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
shawnsingh
jamesr@ for Source/web/ and public/web/ vollick@ for Source/core/ PTAL, thanks!
7 years, 1 month ago (2013-11-19 00:55:52 UTC) #1
Ian Vollick
On 2013/11/19 00:55:52, shawnsingh wrote: > jamesr@ for Source/web/ and public/web/ > vollick@ for Source/core/ ...
7 years, 1 month ago (2013-11-19 02:30:01 UTC) #2
shawnsingh
jamesr@ can you please review/stamp for Source/web/ and public/web? Just adding a flag for layer ...
7 years, 1 month ago (2013-11-20 01:33:07 UTC) #3
jochen (gone - plz use gerrit)
can you add layout tests for this (since you added it to internal.settings already it ...
7 years, 1 month ago (2013-11-20 09:00:32 UTC) #4
shawnsingh
On 2013/11/20 09:00:32, jochen wrote: > can you add layout tests for this (since you ...
7 years, 1 month ago (2013-11-20 18:14:01 UTC) #5
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-21 13:17:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shawnsingh@chromium.org/75823002/130001
7 years, 1 month ago (2013-11-21 21:57:50 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 23:59:57 UTC) #8
Message was sent while issue was closed.
Change committed as 162497

Powered by Google App Engine
This is Rietveld 408576698