Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 758173002: Make arguments to NamedNodeMap methods non-optional (Closed)

Created:
6 years ago by philipj_slow
Modified:
6 years ago
Reviewers:
pdr.
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M LayoutTests/fast/dom/NamedNodeMap-missing-arguments.html View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/NamedNodeMap-missing-arguments-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/shadow/set-attribute-in-shadow-crash.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NamedNodeMap.idl View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
tests
6 years ago (2014-11-25 22:19:07 UTC) #1
philipj_slow
PTAL
6 years ago (2014-11-25 22:22:44 UTC) #3
pdr.
lgtm
6 years ago (2014-11-25 23:30:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/758173002/20001
6 years ago (2014-11-25 23:31:32 UTC) #6
commit-bot: I haz the power
6 years ago (2014-11-26 00:31:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185985

Powered by Google App Engine
This is Rietveld 408576698