LayoutTests/fast/dom/shadow/set-attribute-in-shadow-crash.html - Issue 758173002: Make arguments to NamedNodeMap methods non-optional

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/shadow/set-attribute-in-shadow-crash.html

Issue 758173002: Make arguments to NamedNodeMap methods non-optional (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: tests Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <div id="host"></div>	3 <div id="host"></div>

4 <script>	4 <script>

5 description('Tests that setting an attribute in Shadow DOM does not cause a cras h.');	5 description('Tests that setting an attribute in Shadow DOM does not cause a cras h.');

6	6

7 var host = document.querySelector('#host');	7 var host = document.querySelector('#host');

8 var root = host.createShadowRoot();	8 var root = host.createShadowRoot();

9 root.innerHTML = '<div></div>';	9 root.innerHTML = '<div></div>';

10 var elem = root.firstChild;	10 var elem = root.firstChild;

11 elem.id = 'bar';	11 elem.id = 'bar';

12 var attr = elem.attributes.item();	12 var attr = elem.attributes.item(0);

13 attr.value = 'bar';	13 attr.value = 'bar';

14 var doc2 = document.implementation.createHTMLDocument('Doc 2');	14 var doc2 = document.implementation.createHTMLDocument('Doc 2');

15 doc2.adoptNode(attr);	15 doc2.adoptNode(attr);

16	16

17 successfullyParsed = true;	17 successfullyParsed = true;

18 </script>	18 </script>

OLD	NEW