Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 758073010: [Merge] Fix appViewGuestInternal error in background pages. (Closed)

Created:
6 years ago by lazyboy
Modified:
6 years ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2214
Project:
chromium
Visibility:
Public.

Description

[Merge] Fix appViewGuestInternal error in background pages. Make appViewGuestInternal available in all channels, note that this doesn't expose <appview> to all channels, appViewEmbedderInternal controls that. Making appViewGuestInternal available in all channel would make require('binding').Binding.create('appViewGuestInternal').generate(); from app_runtime_custom_bindings.js not complain. TBR=lazyboy@chromium.org BUG=437891 Test=Note that this fix is only going to show up in stable/beta. 1) Get unpacked calculator app from here: https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/calculator 2) This app has background page. Open the app in chrome stable or beta. 3) Right click and select "Inspect background page". The following error in background page's console should not show up. "chrome.appViewInternal is not available: 'appViewInternal' requires Google Chrome dev channel or newer, but this is the stable channel." Review URL: https://codereview.chromium.org/773583003 Cr-Commit-Position: refs/heads/master@{#306310} (cherry picked from commit 26e03835341edc959c4d69c1c01346c1f3cec99d) Committed: https://chromium.googlesource.com/chromium/src/+/7e8f4446851eadda4cfecf4933be1ed3e736fd5b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M extensions/common/api/_api_features.json View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
lazyboy
6 years ago (2014-12-04 22:23:56 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e8f4446851eadda4cfecf4933be1ed3e736fd5b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698