Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 773583003: Fix appViewGuestInternal error in background pages. (Closed)

Created:
6 years ago by lazyboy
Modified:
6 years ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix appViewGuestInternal error in background pages. Make appViewGuestInternal available in all channels, note that this doesn't expose <appview> to all channels, appViewEmbedderInternal controls that. Making appViewGuestInternal available in all channel would make require('binding').Binding.create('appViewGuestInternal').generate(); from app_runtime_custom_bindings.js not complain. BUG=437891 Test=Note that this fix is only going to show up in stable/beta. 1) Get unpacked calculator app from here: https://github.com/GoogleChrome/chrome-app-samples/tree/master/samples/calculator 2) This app has background page. Open the app in chrome stable or beta. 3) Right click and select "Inspect background page". The following error in background page's console should not show up. "chrome.appViewInternal is not available: 'appViewInternal' requires Google Chrome dev channel or newer, but this is the stable channel." Committed: https://crrev.com/26e03835341edc959c4d69c1c01346c1f3cec99d Cr-Commit-Position: refs/heads/master@{#306310}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add bug reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M extensions/common/api/_api_features.json View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
lazyboy
6 years ago (2014-12-01 20:58:49 UTC) #2
Fady Samuel
lgtm
6 years ago (2014-12-01 21:00:26 UTC) #3
lazyboy
+kalman for reviewing.
6 years ago (2014-12-01 21:19:06 UTC) #5
not at google - send to devlin
lgtm https://chromiumcodereview.appspot.com/773583003/diff/1/extensions/common/api/_api_features.json File extensions/common/api/_api_features.json (right): https://chromiumcodereview.appspot.com/773583003/diff/1/extensions/common/api/_api_features.json#newcode81 extensions/common/api/_api_features.json:81: // appViewEmbedderInternal is required for that. Reference the ...
6 years ago (2014-12-01 23:28:34 UTC) #6
lazyboy
https://chromiumcodereview.appspot.com/773583003/diff/1/extensions/common/api/_api_features.json File extensions/common/api/_api_features.json (right): https://chromiumcodereview.appspot.com/773583003/diff/1/extensions/common/api/_api_features.json#newcode81 extensions/common/api/_api_features.json:81: // appViewEmbedderInternal is required for that. On 2014/12/01 23:28:34, ...
6 years ago (2014-12-01 23:57:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/773583003/20001
6 years ago (2014-12-02 00:07:22 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years ago (2014-12-02 01:10:11 UTC) #10
commit-bot: I haz the power
6 years ago (2014-12-02 01:10:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/26e03835341edc959c4d69c1c01346c1f3cec99d
Cr-Commit-Position: refs/heads/master@{#306310}

Powered by Google App Engine
This is Rietveld 408576698