Source/core/css/resolver/StyleBuilderCustom.cpp - Issue 758073003: Always propagate direction and writing-mode from <body>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 758073003: Always propagate direction and writing-mode from <body>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added XML and overconstraining tests. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleBuilderCustom.cpp

diff --git a/Source/core/css/resolver/StyleBuilderCustom.cpp b/Source/core/css/resolver/StyleBuilderCustom.cpp

index 03d146e5fde0a57ca966bc3b334e1ad441ab4b87..849252c1e6e9c1ea1a2812d14d89b53147d0aca8 100644

--- a/Source/core/css/resolver/StyleBuilderCustom.cpp

+++ b/Source/core/css/resolver/StyleBuilderCustom.cpp

@@ -252,9 +252,6 @@ void StyleBuilderFunctions::applyValueCSSPropertyCursor(StyleResolverState& stat

void StyleBuilderFunctions::applyValueCSSPropertyDirection(StyleResolverState& state, CSSValue* value)

{

state.style()->setDirection(*toCSSPrimitiveValue(value));

- Element* element = state.element();

- if (element && element == element->document().documentElement())

- element->document().setDirectionSetOnDocumentElement(true);

}

void StyleBuilderFunctions::applyValueCSSPropertyGlyphOrientationVertical(StyleResolverState& state, CSSValue* value)

@@ -877,9 +874,6 @@ void StyleBuilderFunctions::applyValueCSSPropertyWebkitWritingMode(StyleResolver

{

if (value->isPrimitiveValue())

state.setWritingMode(*toCSSPrimitiveValue(value));

- // FIXME: It is not ok to modify document state while applying style.

- if (state.element() && state.element() == state.document().documentElement())

- state.document().setWritingModeSetOnDocumentElement(true);

}

void StyleBuilderFunctions::applyValueCSSPropertyWebkitTextOrientation(StyleResolverState& state, CSSValue* value)

« no previous file with comments | « Source/core/css/resolver/MatchedPropertiesCache.cpp ('k') | Source/core/css/resolver/StyleResolver.cpp » ('j') | no next file with comments »